Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang implementation #25

Open
lowesyang opened this issue May 28, 2019 · 2 comments
Open

Golang implementation #25

lowesyang opened this issue May 28, 2019 · 2 comments

Comments

@lowesyang
Copy link

lowesyang commented May 28, 2019 •
edited
Loading

I'm not sure this's the right place to issue that -- I've completed the wasm metering injector in Golang at this repo, and have past the core test cases the same as js-wasm-metering. Can it be added to the ewasm org?
@axic
Copy link
Member

axic commented May 28, 2019

Nice!

It seems it is using the JSON format used by this repository. We do not currently use that format actively and the test cases might be outdated, but we definitely need to get someone to maintain them.

Let me check in with the team what they think.

@lowesyang
Copy link
Author

lowesyang commented May 28, 2019 •
edited
Loading

OK~ And what's the format used currently?
Some test cases are outdated in deed, and i've fixed them and generate new wasm files for testing. Of course it will need more test files, and hope for community help~
Maybe the Golang implementation can also be a typical model or a simple lib to help to build wasmvm MVP (because lots of blockchain VM implemented in Golang) or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axic @lowesyang