fix: DateRange - startdate flicker to epoch0, auto enddate decrease and larger range selection #1893
+64
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1875
closes #1892
Problems Identified:
query
depends ondata
which depends on$input[name].(start & end)
which depends onstartString
&endString
which depends back onquery
.$query
is required to be run once to get date range for available data, but here it is getting triggered repeatedly due to reactive dependencies. When$query
was being refetched startString null coalesce to epoch0 and endString null coalesce to todays date.selectedDateRange
changes$input[name].(start & end)
which changesstartString
&endString
due to above mentioned infinite call. This disables dates outside current selection.dateToYYYYMMDD
function usedDate.toISOString()
method, which has date in UTC format. This results in previous date for some locale. This combined with infinite call bug, was repeatedly decrementing end date.Checklist