Releases: evanw/esbuild
v0.18.18
-
Fix asset references with the
--line-limit
flag (#3286)The recently-released
--line-limit
flag tells esbuild to terminate long lines after they pass this length limit. This includes automatically wrapping long strings across multiple lines using escaped newline syntax. However, using this could cause esbuild to generate incorrect code for references from generated output files to assets in the bundle (i.e. files loaded with thefile
orcopy
loaders). This is because esbuild implements asset references internally using find-and-replace with a randomly-generated string, but the find operation fails if the string is split by an escaped newline due to line wrapping. This release fixes the problem by not wrapping these strings. This issue affected asset references in both JS and CSS files. -
Support local names in CSS for
@keyframe
,@counter-style
, and@container
(#20)This release extends support for local names in CSS files loaded with the
local-css
loader to cover the@keyframe
,@counter-style
, and@container
rules (and alsoanimation
,list-style
, andcontainer
declarations). Here's an example:@keyframes pulse { from, to { opacity: 1 } 50% { opacity: 0.5 } } @counter-style moon { system: cyclic; symbols: π π π π π π π π; } @container squish { li { float: left } } ul { animation: 2s ease-in-out infinite pulse; list-style: inside moon; container: squish / size; }
With the
local-css
loader enabled, that CSS will be turned into something like this (with the local name mapping exposed to JS):@keyframes stdin_pulse { from, to { opacity: 1; } 50% { opacity: 0.5; } } @counter-style stdin_moon { system: cyclic; symbols: π π π π π π π π; } @container stdin_squish { li { float: left; } } ul { animation: 2s ease-in-out infinite stdin_pulse; list-style: inside stdin_moon; container: stdin_squish / size; }
If you want to use a global name within a file loaded with the
local-css
loader, you can use a:global
selector to do that:div { /* All symbols are global inside this scope (i.e. * "pulse", "moon", and "squish" are global below) */ :global { animation: 2s ease-in-out infinite pulse; list-style: inside moon; container: squish / size; } }
If you want to use
@keyframes
,@counter-style
, or@container
with a global name, make sure it's in a file that uses thecss
orglobal-css
loader instead of thelocal-css
loader. For example, you can configure--loader:.module.css=local-css
so that thelocal-css
loader only applies to*.module.css
files. -
Support strings as keyframe animation names in CSS (#2555)
With this release, esbuild will now parse animation names that are specified as strings and will convert them to identifiers. The CSS specification allows animation names to be specified using either identifiers or strings but Chrome only understands identifiers, so esbuild will now always convert string names to identifier names for Chrome compatibility:
/* Original code */ @keyframes "hide menu" { from { opacity: 1 } to { opacity: 0 } } menu.hide { animation: 0.5s ease-in-out "hide menu"; } /* Old output */ @keyframes "hide menu" { from { opacity: 1 } to { opacity: 0 } } menu.hide { animation: 0.5s ease-in-out "hide menu"; } /* New output */ @keyframes hide\ menu { from { opacity: 1; } to { opacity: 0; } } menu.hide { animation: 0.5s ease-in-out hide\ menu; }
v0.18.17
-
Support
An+B
syntax and:nth-*()
pseudo-classes in CSSThis adds support for the
:nth-child()
,:nth-last-child()
,:nth-of-type()
, and:nth-last-of-type()
pseudo-classes to esbuild, which has the following consequences:- The
An+B
syntax is now parsed, so parse errors are now reported An+B
values inside these pseudo-classes are now pretty-printed (e.g. a leading+
will be stripped because it's not in the AST)- When minification is enabled,
An+B
values are reduced to equivalent but shorter forms (e.g.2n+0
=>2n
,2n+1
=>odd
) - Local CSS names in an
of
clause are now detected (e.g. in:nth-child(2n of :local(.foo))
the namefoo
is now renamed)
/* Original code */ .foo:nth-child(+2n+1 of :local(.bar)) { color: red; } /* Old output (with --loader=local-css) */ .stdin_foo:nth-child(+2n + 1 of :local(.bar)) { color: red; } /* New output (with --loader=local-css) */ .stdin_foo:nth-child(2n+1 of .stdin_bar) { color: red; }
- The
-
Adjust CSS nesting parser for IE7 hacks (#3272)
This fixes a regression with esbuild's treatment of IE7 hacks in CSS. CSS nesting allows selectors to be used where declarations are expected. There's an IE7 hack where prefixing a declaration with a
*
causes that declaration to only be applied in IE7 due to a bug in IE7's CSS parser. However, it's valid for nested CSS selectors to start with*
. So esbuild was incorrectly parsing these declarations and anything following it up until the next{
as a selector for a nested CSS rule. This release changes esbuild's parser to terminate the parsing of selectors for nested CSS rules when a;
is encountered to fix this edge case:/* Original code */ .item { *width: 100%; height: 1px; } /* Old output */ .item { *width: 100%; height: 1px; { } } /* New output */ .item { *width: 100%; height: 1px; }
Note that the syntax for CSS nesting is about to change again, so esbuild's CSS parser may still not be completely accurate with how browsers do and/or will interpret CSS nesting syntax. Expect additional updates to esbuild's CSS parser in the future to deal with upcoming CSS specification changes.
-
Adjust esbuild's warning about undefined imports for TypeScript
import
equals declarations (#3271)In JavaScript, accessing a missing property on an import namespace object is supposed to result in a value of
undefined
at run-time instead of an error at compile-time. This is something that esbuild warns you about by default because doing this can indicate a bug with your code. For example:// app.js import * as styles from './styles' console.log(styles.buton)
// styles.js export let button = {}
If you bundle
app.js
with esbuild you will get this:β² [WARNING] Import "buton" will always be undefined because there is no matching export in "styles.js" [import-is-undefined] app.js:2:19: 2 β console.log(styles.buton) β ~~~~~ β΅ button Did you mean to import "button" instead? styles.js:1:11: 1 β export let button = {} β΅ ~~~~~~
However, there is TypeScript-only syntax for
import
equals declarations that can represent either a type import (which esbuild should ignore) or a value import (which esbuild should respect). Since esbuild doesn't have a type system, it tries to only respectimport
equals declarations that are actually used as values. Previously esbuild always generated this warning for unused imports referenced withinimport
equals declarations even when the reference could be a type instead of a value. Starting with this release, esbuild will now only warn in this case if the import is actually used. Here is an example of some code that no longer causes an incorrect warning:// app.ts import * as styles from './styles' import ButtonType = styles.Button
// styles.ts export interface Button {}
v0.18.16
-
Fix a regression with whitespace inside
:is()
(#3265)The change to parse the contents of
:is()
in version 0.18.14 introduced a regression that incorrectly flagged the contents as a syntax error if the contents started with a whitespace token (for examplediv:is( .foo ) {}
). This regression has been fixed.
v0.18.15
-
Add the
--serve-fallback=
option (#2904)The web server built into esbuild serves the latest in-memory results of the configured build. If the requested path doesn't match any in-memory build result, esbuild also provides the
--servedir=
option to tell esbuild to serve the requested path from that directory instead. And if the requested path doesn't match either of those things, esbuild will either automatically generate a directory listing (for directories) or return a 404 error.Starting with this release, that last step can now be replaced with telling esbuild to serve a specific HTML file using the
--serve-fallback=
option. This can be used to provide a "not found" page for missing URLs. It can also be used to implement a single-page app that mutates the current URL and therefore requires the single app entry point to be served when the page is loaded regardless of whatever the current URL is. -
Use the
tsconfig
field inpackage.json
duringextends
resolution (#3247)This release adds a feature from TypeScript 3.2 where if a
tsconfig.json
file specifies a package name in theextends
field and that package'spackage.json
file has atsconfig
field, the contents of that field are used in the search for the basetsconfig.json
file. -
Implement CSS nesting without
:is()
when possible (#1945)Previously esbuild would always produce a warning when transforming nested CSS for a browser that doesn't support the
:is()
pseudo-class. This was because the nesting transform needs to generate an:is()
in some complex cases which means the transformed CSS would then not work in that browser. However, the CSS nesting transform can often be done without generating an:is()
. So with this release, esbuild will no longer warn when targeting browsers that don't support:is()
in the cases where an:is()
isn't needed to represent the nested CSS.In addition, esbuild's nested CSS transform has been updated to avoid generating an
:is()
in cases where an:is()
is preferable but there's a longer alternative that is also equivalent. This update means esbuild can now generate a combinatorial explosion of CSS for complex CSS nesting syntax when targeting browsers that don't support:is()
. This combinatorial explosion is necessary to accurately represent the original semantics. For example:/* Original code */ .first, .second, .third { & > & { color: red; } } /* Old output (with --target=chrome80) */ :is(.first, .second, .third) > :is(.first, .second, .third) { color: red; } /* New output (with --target=chrome80) */ .first > .first, .first > .second, .first > .third, .second > .first, .second > .second, .second > .third, .third > .first, .third > .second, .third > .third { color: red; }
This change means you can now use CSS nesting with esbuild when targeting an older browser that doesn't support
:is()
. You'll now only get a warning from esbuild if you use complex CSS nesting syntax that esbuild can't represent in that older browser without using:is()
. There are two such cases:/* Case 1 */ a b { .foo & { color: red; } } /* Case 2 */ a { > b& { color: red; } }
These two cases still need to use
:is()
, both for different reasons, and cannot be used when targeting an older browser that doesn't support:is()
:/* Case 1 */ .foo :is(a b) { color: red; } /* Case 2 */ a > a:is(b) { color: red; }
-
Automatically lower
inset
in CSS for older browsersWith this release, esbuild will now automatically expand the
inset
property to thetop
,right
,bottom
, andleft
properties when esbuild'starget
is set to a browser that doesn't supportinset
:/* Original code */ .app { position: absolute; inset: 10px 20px; } /* Old output (with --target=chrome80) */ .app { position: absolute; inset: 10px 20px; } /* New output (with --target=chrome80) */ .app { position: absolute; top: 10px; right: 20px; bottom: 10px; left: 20px; }
-
Add support for the new
@starting-style
CSS rule (#3249)This at rule allow authors to start CSS transitions on first style update. That is, you can now make the transition take effect when the
display
property changes fromnone
toblock
./* Original code */ @starting-style { h1 { background-color: transparent; } } /* Output */ @starting-style{h1{background-color:transparent}}
This was contributed by @yisibl.
v0.18.14
-
Implement local CSS names (#20)
This release introduces two new loaders called
global-css
andlocal-css
and two new pseudo-class selectors:local()
and:global()
. This is a partial implementation of the popular CSS modules approach for avoiding unintentional name collisions in CSS. I'm not calling this feature "CSS modules" because although some people in the community call it that, other people in the community have started using "CSS modules" to refer to something completely different and now CSS modules is an overloaded term.Here's how this new local CSS name feature works with esbuild:
-
Identifiers that look like
.className
and#idName
are global with theglobal-css
loader and local with thelocal-css
loader. Global identifiers are the same across all files (the way CSS normally works) but local identifiers are different between different files. If two separate CSS files use the same local identifier.button
, esbuild will automatically rename one of them so that they don't collide. This is analogous to how esbuild automatically renames JS local variables with the same name in separate JS files to avoid name collisions. -
It only makes sense to use local CSS names with esbuild when you are also using esbuild's bundler to bundle JS files that import CSS files. When you do that, esbuild will generate one export for each local name in the CSS file. The JS code can import these names and use them when constructing HTML DOM. For example:
// app.js import { outerShell } from './app.css' const div = document.createElement('div') div.className = outerShell document.body.appendChild(div)
/* app.css */ .outerShell { position: absolute; inset: 0; }
When you bundle this with
esbuild app.js --bundle --loader:.css=local-css --outdir=out
you'll now get this (notice how the local CSS nameouterShell
has been renamed):// out/app.js (() => { // app.css var outerShell = "app_outerShell"; // app.js var div = document.createElement("div"); div.className = outerShell; document.body.appendChild(div); })();
/* out/app.css */ .app_outerShell { position: absolute; inset: 0; }
This feature only makes sense to use when bundling is enabled both because your code needs to
import
the renamed local names so that it can use them, and because esbuild needs to be able to process all CSS files containing local names in a single bundling operation so that it can successfully rename conflicting local names to avoid collisions. -
If you are in a global CSS file (with the
global-css
loader) you can create a local name using:local()
, and if you are in a local CSS file (with thelocal-css
loader) you can create a global name with:global()
. So the choice of theglobal-css
loader vs. thelocal-css
loader just sets the default behavior for identifiers, but you can override it on a case-by-case basis as necessary. For example::local(.button) { color: red; } :global(.button) { color: blue; }
Processing this CSS file with esbuild with either the
global-css
orlocal-css
loader will result in something like this:.stdin_button { color: red; } .button { color: blue; }
-
The names that esbuild generates for local CSS names are an implementation detail and are not intended to be hard-coded anywhere. The only way you should be referencing the local CSS names in your JS or HTML is with an
import
statement in JS that is bundled with esbuild, as demonstrated above. For example, when--minify
is enabled esbuild will use a different name generation algorithm which generates names that are as short as possible (analogous to how esbuild minifies local identifiers in JS). -
You can easily use both global CSS files and local CSS files simultaneously if you give them different file extensions. For example, you could pass
--loader:.css=global-css
and--loader:.module.css=local-css
to esbuild so that.css
files still use global names by default but.module.css
files use local names by default. -
Keep in mind that the
css
loader is different than theglobal-css
loader. The:local
and:global
annotations are not enabled with thecss
loader and will be passed through unchanged. This allows you to have the option of using esbuild to process CSS containing while preserving these annotations. It also means that local CSS names are disabled by default for now (since thecss
loader is currently the default for CSS files). The:local
and:global
syntax may be enabled by default in a future release.
Note that esbuild's implementation does not currently have feature parity with other implementations of modular CSS in similar tools. This is only a preliminary release with a partial implementation that includes some basic behavior to get the process started. Additional behavior may be added in future releases. In particular, this release does not implement:
- The
composes
pragma - Tree shaking for unused local CSS
- Local names for keyframe animations, grid lines,
@container
,@counter-style
, etc.
Issue #20 (the issue for this feature) is esbuild's most-upvoted issue! While this release still leaves that issue open, it's an important first step in that direction.
-
-
Parse
:is
,:has
,:not
, and:where
in CSSWith this release, esbuild will now parse the contents of these pseudo-class selectors as a selector list. This means you will now get syntax warnings within these selectors for invalid selector syntax. It also means that esbuild's CSS nesting transform behaves slightly differently than before because esbuild is now operating on an AST instead of a token stream. For example:
/* Original code */ div { :where(.foo&) { color: red; } } /* Old output (with --target=chrome90) */ :where(.foo:is(div)) { color: red; } /* New output (with --target=chrome90) */ :where(div.foo) { color: red; }
v0.18.13
-
Add the
--drop-labels=
option (#2398)If you want to conditionally disable some development-only code and have it not be present in the final production bundle, right now the most straightforward way of doing this is to use the
--define:
flag along with a specially-named global variable. For example, consider the following code:function main() { DEV && doAnExpensiveCheck() }
You can build this for development and production like this:
- Development:
esbuild --define:DEV=true
- Production:
esbuild --define:DEV=false
One drawback of this approach is that the resulting code crashes if you don't provide a value for
DEV
with--define:
. In practice this isn't that big of a problem, and there are also various ways to work around this.However, another approach that avoids this drawback is to use JavaScript label statements instead. That's what the
--drop-labels=
flag implements. For example, consider the following code:function main() { DEV: doAnExpensiveCheck() }
With this release, you can now build this for development and production like this:
- Development:
esbuild
- Production:
esbuild --drop-labels=DEV
This means that code containing optional development-only checks can now be written such that it's safe to run without any additional configuration. The
--drop-labels=
flag takes comma-separated list of multiple label names to drop. - Development:
-
Avoid causing
unhandledRejection
during shutdown (#3219)All pending esbuild JavaScript API calls are supposed to fail if esbuild's underlying child process is unexpectedly terminated. This can happen if
SIGINT
is sent to the parentnode
process with Ctrl+C, for example. Previously doing this could also cause an unhandled promise rejection when esbuild attempted to communicate this failure to its own child process that no longer exists. This release now swallows this communication failure, which should prevent this internal unhandled promise rejection. This change means that you can now use esbuild's JavaScript API with a customSIGINT
handler that extends the lifetime of thenode
process without esbuild's internals causing an early exit due to an unhandled promise rejection. -
Update browser compatibility table scripts
The scripts that esbuild uses to compile its internal browser compatibility table have been overhauled. Briefly:
- Converted from JavaScript to TypeScript
- Fixed some bugs that resulted in small changes to the table
- Added
caniuse-lite
and@mdn/browser-compat-data
as new data sources (replacing manually-copied information)
This change means it's now much easier to keep esbuild's internal compatibility tables up to date. You can review the table changes here if you need to debug something about this change:
v0.18.12
-
Fix a panic with
const enum
inside parentheses (#3205)This release fixes an edge case where esbuild could potentially panic if a TypeScript
const enum
statement was used inside of a parenthesized expression and was followed by certain other scope-related statements. Here's a minimal example that triggers this edge case:(() => { const enum E { a }; () => E.a })
-
Allow a newline in the middle of TypeScript
export type
statement (#3225)Previously esbuild incorrectly rejected the following valid TypeScript code:
export type { T }; export type * as foo from 'bar';
Code that uses a newline after
export type
is now allowed starting with this release. -
Fix cross-module inlining of string enums (#3210)
A refactoring typo in version 0.18.9 accidentally introduced a regression with cross-module inlining of string enums when combined with computed property accesses. This regression has been fixed.
-
Rewrite
.js
to.ts
inside packages withexports
(#3201)Packages with the
exports
field are supposed to disable node's path resolution behavior that allows you to import a file with a different extension than the one in the source code (for example, importingfoo/bar
to getfoo/bar.js
). And TypeScript has behavior where you can import a non-existent.js
file and you will get the.ts
file instead. Previously the presence of theexports
field caused esbuild to disable all extension manipulation stuff which included both node's implicit file extension searching and TypeScript's file extension swapping. However, TypeScript appears to always apply file extension swapping even in this case. So with this release, esbuild will now rewrite.js
to.ts
even inside packages withexports
. -
Fix a redirect edge case in esbuild's development server (#3208)
The development server canonicalizes directory URLs by adding a trailing slash. For example, visiting
/about
redirects to/about/
if/about/index.html
would be served. However, if the requested path begins with two slashes, then the redirect incorrectly turned into a protocol-relative URL. For example, visiting//about
redirected to//about/
which the browser turns intohttp://about/
. This release fixes the bug by canonicalizing the URL path when doing this redirect.
v0.18.11
-
Fix a TypeScript code generation edge case (#3199)
This release fixes a regression in version 0.18.4 where using a TypeScript
namespace
that exports aclass
declaration combined with--keep-names
and a--target
ofes2021
or earlier could cause esbuild to export the class from the namespace using an incorrect name (notice the assignment toX2._Y
vs.X2.Y
):// Original code // Old output (with --keep-names --target=es2021) var X; ((X2) => { const _Y = class _Y { }; __name(_Y, "Y"); let Y = _Y; X2._Y = _Y; })(X || (X = {})); // New output (with --keep-names --target=es2021) var X; ((X2) => { const _Y = class _Y { }; __name(_Y, "Y"); let Y = _Y; X2.Y = _Y; })(X || (X = {}));
v0.18.10
-
Fix a tree-shaking bug that removed side effects (#3195)
This fixes a regression in version 0.18.4 where combining
--minify-syntax
with--keep-names
could cause expressions with side effects after a function declaration to be considered side-effect free for tree shaking purposes. The reason was because--keep-names
generates an expression statement containing a call to a helper function after the function declaration with a special flag that makes the function call able to be tree shaken, and then--minify-syntax
could potentially merge that expression statement with following expressions without clearing the flag. This release fixes the bug by clearing the flag when merging expression statements together. -
Fix an incorrect warning about CSS nesting (#3197)
A warning is currently generated when transforming nested CSS to a browser that doesn't support
:is()
because transformed nested CSS may need to use that feature to represent nesting. This was previously always triggered when an at-rule was encountered in a declaration context. Typically the only case you would encounter this is when using CSS nesting within a selector rule. However, there is a case where that's not true: when using a margin at-rule such as@top-left
within@page
. This release avoids incorrectly generating a warning in this case by checking that the at-rule is within a selector rule before generating a warning.
v0.18.9
-
Fix
await using
declarations insideasync
generator functionsI forgot about the new
await using
declarations when implementing lowering forasync
generator functions in the previous release. This change fixes the transformation ofawait using
declarations when they are inside loweredasync
generator functions:// Original code async function* foo() { await using x = await y } // Old output (with --supported:async-generator=false) function foo() { return __asyncGenerator(this, null, function* () { await using x = yield new __await(y); }); } // New output (with --supported:async-generator=false) function foo() { return __asyncGenerator(this, null, function* () { var _stack = []; try { const x = __using(_stack, yield new __await(y), true); } catch (_) { var _error = _, _hasError = true; } finally { var _promise = __callDispose(_stack, _error, _hasError); _promise && (yield new __await(_promise)); } }); }
-
Insert some prefixed CSS properties when appropriate (#3122)
With this release, esbuild will now insert prefixed CSS properties in certain cases when the
target
setting includes browsers that require a certain prefix. This is currently done for the following properties:appearance: *;
=>-webkit-appearance: *; -moz-appearance: *;
backdrop-filter: *;
=>-webkit-backdrop-filter: *;
background-clip: text
=>-webkit-background-clip: text;
box-decoration-break: *;
=>-webkit-box-decoration-break: *;
clip-path: *;
=>-webkit-clip-path: *;
font-kerning: *;
=>-webkit-font-kerning: *;
hyphens: *;
=>-webkit-hyphens: *;
initial-letter: *;
=>-webkit-initial-letter: *;
mask-image: *;
=>-webkit-mask-image: *;
mask-origin: *;
=>-webkit-mask-origin: *;
mask-position: *;
=>-webkit-mask-position: *;
mask-repeat: *;
=>-webkit-mask-repeat: *;
mask-size: *;
=>-webkit-mask-size: *;
position: sticky;
=>position: -webkit-sticky;
print-color-adjust: *;
=>-webkit-print-color-adjust: *;
tab-size: *;
=>-moz-tab-size: *; -o-tab-size: *;
text-decoration-color: *;
=>-webkit-text-decoration-color: *; -moz-text-decoration-color: *;
text-decoration-line: *;
=>-webkit-text-decoration-line: *; -moz-text-decoration-line: *;
text-decoration-skip: *;
=>-webkit-text-decoration-skip: *;
text-emphasis-color: *;
=>-webkit-text-emphasis-color: *;
text-emphasis-position: *;
=>-webkit-text-emphasis-position: *;
text-emphasis-style: *;
=>-webkit-text-emphasis-style: *;
text-orientation: *;
=>-webkit-text-orientation: *;
text-size-adjust: *;
=>-webkit-text-size-adjust: *; -ms-text-size-adjust: *;
user-select: *;
=>-webkit-user-select: *; -moz-user-select: *; -ms-user-select: *;
Here is an example:
/* Original code */ div { mask-image: url(x.png); } /* Old output (with --target=chrome99) */ div { mask-image: url(x.png); } /* New output (with --target=chrome99) */ div { -webkit-mask-image: url(x.png); mask-image: url(x.png); }
Browser compatibility data was sourced from the tables on https://caniuse.com. Support for more CSS properties can be added in the future as appropriate.
-
Fix an obscure identifier minification bug (#2809)
Function declarations in nested scopes behave differently depending on whether or not
"use strict"
is present. To avoid generating code that behaves differently depending on whether strict mode is enabled or not, esbuild transforms nested function declarations into variable declarations. However, there was a bug where the generated variable name was not being recorded as declared internally, which meant that it wasn't being renamed correctly by the minifier and could cause a name collision. This bug has been fixed:// Original code const n = '' for (let i of [0,1]) { function f () {} } // Old output (with --minify-identifiers --format=esm) const f = ""; for (let o of [0, 1]) { let n = function() { }; var f = n; } // New output (with --minify-identifiers --format=esm) const f = ""; for (let o of [0, 1]) { let n = function() { }; var t = n; }
-
Fix a bug in esbuild's compatibility table script (#3179)
Setting esbuild's
target
to a specific JavaScript engine tells esbuild to use the JavaScript syntax feature compatibility data from https://kangax.github.io/compat-table/es6/ for that engine to determine which syntax features to allow. However, esbuild's script that builds this internal compatibility table had a bug that incorrectly ignores tests for engines that still have outstanding implementation bugs which were never fixed. This change fixes this bug with the script.The only case where this changed the information in esbuild's internal compatibility table is that the
hermes
target is marked as no longer supporting destructuring. This is because there is a failing destructuring-related test for Hermes on https://kangax.github.io/compat-table/es6/. If you want to use destructuring with Hermes anyway, you can pass--supported:destructuring=true
to esbuild to override thehermes
target and force esbuild to accept this syntax.This fix was contributed by @ArrayZoneYour.