-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linker entries less janky for .data (e.g. images) #348
Comments
Currently who is using this feature? |
I'm using it a bit in SSSV, I would use it more if it was less janky 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(copy/pasta from Discord):
The linker names are a little crazy because we are taking the file suffixes and dropping the last one (the aim being to drop the .o)
this leads to the following yaml entry:
- [0x117200, rgba16, img/intro/spaceship_interior.D_04000630_117200, 32, 32]
generating these lines in the
.ld
script:I think the entry in the linker file should be:
This could be done by taking the build_path and removing the prefix (i.e.
build/assets
) and removing the final suffix (i.e..o
).This would probably be a breaking change for people though (even if the only change was the double underscores becoming single underscores.
The text was updated successfully, but these errors were encountered: