-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethers.js calling gasPrice once again for BSC #4687
Comments
The result changes depending on which network you use. Example -
|
Yes. The gas price depends on network; that’s just how gas works. :) Ethereum uses EIP-1337, so the fees are protocol defined (based on recent block congestion). BSC uses a bidding system, so the miners choose the gas price based on what a transaction is willing to pay. |
@mahatotarit @ricmoo Yes, but the problem is that current code will just send request to node even when I already specify the gasPrice and it is odd since when there is already a gasPrice ethers.js wouldn't apply it so why sending an additional request when we wouldn't override them? |
@tornadocontrib I agree that is something I will optimize. My previous comment was regarding the comment by @mahatotarit. I’m working on it. It just takes time. :) |
@ricmoo BTW, is there any specific reason to block "from" field for I think it would be helpful to restrict transaction being signed by a specific signer but don't know if it would be appropriate. |
@tornadocontrib You can specify For example, when you set the The key thing to keep in mind is that there isn’t actually a Does that make sense? |
@ricmoo Yes, didn't notice since I haven't read the full codebase but thanks for clarification, was working on the transaction serialization for offline signing though. |
Describe the Problem
Fixed by #4686
The text was updated successfully, but these errors were encountered: