Add the block size and withdrawal fields to eth_getBlockByHash #1244
Conversation
akorchyn
changed the title
|
I don't really understand these failing tests. Could somebody point out the direction of the problem? |
| @@ -397,7 +418,7 @@ impl BlobTransaction { | |||
| + self.gas_limit.length() | |||
| + self.to.length() | |||
| + self.value.length() | |||
| + self.data.len() | |||
| + self.data.length() | |||
There was a problem hiding this comment.
| + self.data.length() | |
| + self.data.len() |
change this back to len() and see if it works
There was a problem hiding this comment.
It actually doesn't change anything from the perspective of encoding length. I have changed it just to keep it the same for all fields_len methods :)
There was a problem hiding this comment.
But I tried, and the test still failed.
There was a problem hiding this comment.
I thought there might be an issue with transaction encoding, but it seems fine. I have added couple of tests if you don't mind
There was a problem hiding this comment.
Nothing wrong with adding tests
I would dump one that failed with one that didn't fail and output the values as hex. This isn't really my priority to look into what is causing this problem at the moment, but impl From<Withdrawal> for reth_rpc_types::Withdrawal { if you remove this and nothing else does it work again?
There was a problem hiding this comment.
My idea is maybe this is causing a .into() elsewhere in the code to pull this instead for some unknown reason, but that is just my best guess not really looking into this
There was a problem hiding this comment.
Thank you for your help anyway. I ll look it in coming days
…sts on transaction encoding
What was wrong?
Resolves: #960
How was it fixed?
I have added length implementations for a couple of structs.
I added the
withdrawalsandsizefields to eth_getBlockHashI noticed that the implementation of transaction size wasn't evaluated correctly. As per default implementation, the length is calculated from encode().len().
Is it possible that transaction encoding is implemented incorrectly?
To-Do