Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bootnode: remove bootnode utility #30813

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

MariusVanDerWijden
Copy link
Member

Since we don't really support custom networks anymore, we don't need the bootnode utility anymore.

Since we're not supporting creating custom networks anymore,
it makes little sense to still have the bootnode utility,
except for creating the nodekey
@MariusVanDerWijden MariusVanDerWijden marked this pull request as ready for review November 26, 2024 11:23
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl
Copy link
Contributor

fjl commented Nov 28, 2024

The PR is correct, but honestly that whole section of the README just has to be deleted. We shouldn't try to fix up the description of creating a private network when it is literally impossible to run one.

@fjl fjl merged commit 53f66c1 into ethereum:master Nov 28, 2024
3 checks passed
@fjl fjl added this to the 1.14.13 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants