Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op.DELEGATECALL accept incorrect number of arguments #441

Open
winsvega opened this issue Feb 15, 2024 · 2 comments
Open

Op.DELEGATECALL accept incorrect number of arguments #441

winsvega opened this issue Feb 15, 2024 · 2 comments

Comments

@winsvega
Copy link
Collaborator

check STATICCALL as well

it looks like I can legitimately write Op.DELEGATECALL( gas, addr, value, x, y, a, b)
and don't notice that it actually should be Op.DELEGATECALL( gas, addr, x, y, a, b)

@winsvega
Copy link
Collaborator Author

so here are the suggestions

Op.CALL()   empty constructor  that assumes tester preares the stack.  and the arguments constructor requires strictly. 
Op.CALL_UNSAFE(...)    the current version of OPCODE 
``

@marioevz
Copy link
Member

marioevz commented Apr 1, 2024

It seems like adding a parameter called unsafe does the trick, like this:

Op.TSTORE(0, unsafe=True)

I have a branch to test this and surprisingly it does not break almost any tests, but it highlighted some potential test errors that I'm taking a look into, so enforcing this seems like a good idea so this does not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants