-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Op.DELEGATECALL accept incorrect number of arguments #441
Comments
so here are the suggestions
|
It seems like adding a parameter called Op.TSTORE(0, unsafe=True) I have a branch to test this and surprisingly it does not break almost any tests, but it highlighted some potential test errors that I'm taking a look into, so enforcing this seems like a good idea so this does not happen again. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
check STATICCALL as well
it looks like I can legitimately write Op.DELEGATECALL( gas, addr, value, x, y, a, b)
and don't notice that it actually should be Op.DELEGATECALL( gas, addr, x, y, a, b)
The text was updated successfully, but these errors were encountered: