Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we need "blocknumber" : "1", in rlp_decoded section of invalid block? #414

Open
winsvega opened this issue Jan 30, 2024 · 2 comments
Open

Comments

@winsvega
Copy link
Collaborator

this field seems to be excessive or unused. because the block number is already in the header. and we now require invalid blocks to have valid RLP structure. so blockheader could be read.

@spencer-tb
Copy link
Collaborator

The only reason I can see it being "useful" is when we have valid blocks before invalid blocks like in this case: https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_tools/tests/test_filling/fixtures/blockchain_london_invalid_filled.json

Then again I don't its needed (unless evmone prefer having it)!
What do you think?

@winsvega
Copy link
Collaborator Author

I see it comes from copy paste of the structures data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants