You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently ChainConfig .toml files do not contain the complete set of config values. Rather, there is logic within the superchain package to inherit/populate some values (namely hardfork activation timestamps and some superchain-wide contract addresses) from the appropriate superchain.toml file. This creates some confusion about how a chain is configured when looking at any given ChainConfig file. We would like to get rid of the inheritance so that the ChainConfig is a fully, self-contained set of information about the chain.
Tradeoffs
Duplicated data across chain configs - worth this tradeoff to be explicit and avoid confusion
Difficult to tell how a chain diverges from default values if default values are not excluded - could alleviate this concern by adding a simple command to the superchain-registry/ops module which could print out the diff?
./ops default-diffs <chain_id>
Acceptance criteria
All current chain configs contain all hardfork timestamp activations for their chain
All current chain configs contain all contract addresses for their chain
ops command exists to propagate new superchain hardfork timestamps to chains who want to inherit them (i.e. superchain_time is set)
ops command exists to show diff between chain config and defaults: ./ops default-diffs <chain_id>
The text was updated successfully, but these errors were encountered:
Overview
Currently
ChainConfig
.toml files do not contain the complete set of config values. Rather, there is logic within thesuperchain
package to inherit/populate some values (namely hardfork activation timestamps and some superchain-wide contract addresses) from the appropriate superchain.toml file. This creates some confusion about how a chain is configured when looking at any givenChainConfig
file. We would like to get rid of the inheritance so that theChainConfig
is a fully, self-contained set of information about the chain.Tradeoffs
Acceptance criteria
superchain_time
is set)./ops default-diffs <chain_id>
The text was updated successfully, but these errors were encountered: