-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The use of .scss format #67
Comments
Doesn't writing Han.css in SCSS better than writing it in SASS? Because SCSS is closer to CSS, doesn't this make new contributors unfamiliar with SASS or SCSS easier to contribute? |
My opinion is that there are hundreds of languages using indentation instead of curly brackets to delimit ranges. I don’t see why we shouldn’t use the Sass format. It is cleaner to look at and easier to write. That’s just a matter of preference. 😄 FYI, the SCSS format is used in some cases in the project, such as listing font-family. https://github.com/ethantw/Han/blob/master/src/sass/typography/ff/_biaodian.scss |
Han.css is developed using .sass format in most cases for its conciseness. From v3.1.0, where we started using Gulp for development, the main files (
src/sass/han.scss
andindex.scss
) switched to .scss format since the module gulp-sass fails to compile .sass files correctly. Will switch back once the bug is fixed.The text was updated successfully, but these errors were encountered: