Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactJS Version 17 Support #121

Open
VenkatKaruna opened this issue Jul 17, 2021 · 5 comments · May be fixed by #127
Open

ReactJS Version 17 Support #121

VenkatKaruna opened this issue Jul 17, 2021 · 5 comments · May be fixed by #127

Comments

@VenkatKaruna
Copy link

The release date for ReactJS Version 17

@divyakumarjain
Copy link

+1

@divyakumarjain
Copy link

#127

@divyakumarjain divyakumarjain linked a pull request Aug 6, 2021 that will close this issue
@gooftroop
Copy link

Hi @divyakumarjain I've forked the project and added support here: https://www.npmjs.com/package/@blacklab/react-image-magnify

As a note, I'm still working through some bugs that resulted in the rewrite. If you use this library and encounter any, please report them as issues in my github repo so I can address them.

Thanks!

@MatrixFrog
Copy link

That's awesome @gooftroop . Do you have a write-up somewhere of what bugs you're still working through? Do you recommend people go ahead and use your version or would you say it's not quite ready for production use?

@gooftroop
Copy link

@MatrixFrog at this moment I'm working through an aspect ratio bug that appears when zooming over very skinny images; other than that the library is production ready (it's currently being used in a production app already), so my recommendation would be to use my fork.
If you're curious on what has been added / fixed, the release notes should have a high level overview of what I've done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants