Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Templating in index.html #36

Open
ethanchewy opened this issue Oct 29, 2018 · 6 comments
Open

Use Templating in index.html #36

ethanchewy opened this issue Oct 29, 2018 · 6 comments

Comments

@ethanchewy
Copy link
Owner

ethanchewy commented Oct 29, 2018

http://flask.pocoo.org/docs/1.0/tutorial/templates/

As a developer, I want to use a templating framework instead of pure HTML

@dgmouris
Copy link
Contributor

dgmouris commented Oct 3, 2019

Really cool project. Huge respect!

What do you mean by templating, do you want to separate out a base.html?

I'd love to help out as I think this project is really neat. Thanks for your time.

@ethanchewy
Copy link
Owner Author

Awesome! Thanks for taking a look at this project.

I was thinking about using Jinja for templating: http://flask.palletsprojects.com/en/1.1.x/tutorial/templates/

Hasn't been necessary in the past since we only have really one HTML file to work with but I want to support in the future perhaps the possibility of users being able to sign in, log out, and view their previous code submissions which would be require templating.

So, this step is mainly converting the raw HTML into a templating system using Jinja to future proof the project when it expands!

For example, we could convert the current index.html into parts like: header, examples, sponsor, text editor, etc.

@dgmouris
Copy link
Contributor

dgmouris commented Oct 3, 2019

Thanks for the really quick response, that's super nice and awesome.

Jinja2 would be a great idea, especially if you're planning project expansion. I'd love to help out doing this if you don't mind.

Let me know if that would be alright with you if I worked on this.

@ethanchewy
Copy link
Owner Author

Yes, go ahead. Feel free to add any questions, comments, or suggestions in this thread throughout the process!

@dgmouris
Copy link
Contributor

dgmouris commented Oct 4, 2019

Awsome @ethanchewy thanks for the help.

@dgmouris
Copy link
Contributor

dgmouris commented Oct 4, 2019

Hey @ethanchewy I've added a lot of blocks just because I think this might be handier in the future.

Let me know if you'd like to explain/remove/add more blocks and I'd be really happy to.

I hope you have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants