Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No BMP/Farbfeld encoder #174

Open
hillin opened this issue Mar 22, 2024 · 1 comment
Open

No BMP/Farbfeld encoder #174

hillin opened this issue Mar 22, 2024 · 1 comment

Comments

@hillin
Copy link
Contributor

hillin commented Mar 22, 2024

I was curious of the performance comparison amongst codecs of different image formats that zune-image supports. Apparently BMP and Farbfeld has no encoding support right now. (Not that I need it, just firing an issue for completeness.)

There seems to be an encoder for Farbfeld, but not supported in write_to_vec.

@hillin hillin changed the title No BMP encoder No BMP/Farbfeld encoder/decoder Mar 22, 2024
@hillin hillin changed the title No BMP/Farbfeld encoder/decoder No BMP/Farbfeld encoder Mar 22, 2024
@etemesi254
Copy link
Owner

more of time constraints, BMP is easy to write an encoder for, but it's not that interesting for me to pursue,but ideally it should be there, the farbfeld one is weird

Also to note, the dev branch overhauled how io is being done, making writes be in anything that implements a certain trait, if you are testing such it would be nice to test on the new traits

particularly I'd love to see tests that see how long it takes to encode to a & mut Vec and also & mut Bufreader <File>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants