-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce old Docsy-overrides where needed/wanted #813
Comments
The banner code can be found here: https://github.com/cncf/docsy/blob/etcd.io/layouts/partials/version-banner.html |
Hi @nate-double-u, if the banner is needed, I can start to work on these. Need information on which versions I have to add those banners. Also, enabling the banners will possibly remove these issues like #837. /cc @jmhbnz |
/assign |
Yes, we still want the warning banners. |
I think the banners would be needed for all the versions except current. All the previous versions would say something like 'archived,' while the next version would say something like 'proposed.' (I can't remember exactly the specific wording, but that's it in a nutshell) |
The partial for version banner has now been reintroduced, thanks @moficodes! Are there any other overrides we want to reintroduce or should we close this now? |
Follow up to #803, it looks like we've lost the old version warning banner. Do we still want/need it? if so, we should reintroduce it.
There are several overrides that got dropped and could be reintroduced. The majority of them can be found in PR cncf/docsy#2
The text was updated successfully, but these errors were encountered: