-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Danger from GitHub Actions + ESP-IDF project #1
Conversation
👋 Hello tomassebestik, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
37cc581
to
0a1323f
Compare
c3abe07
to
e7a60c1
Compare
- docs: add CONTRIBUTING Guide content - docs: add output instructions format
e7a60c1
to
b595088
Compare
@kumekay @dobairoland @alekseiapa PTAL ... it's very similar to Shared Danger Gitlab now. No need for in-depth code review logic, the code has full test coverage and has been tested in an external repo. Split to commits in logic sections. Many thanks, guys! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. I didn't do a detailed review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomassebestik I made a relatively quick review, but nothing catches my eye, looks good, thank you
Summary of changes
with:
section.Updated rules
Output instructions
Styles
Tested
Related
Next steps