-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle fixup and squash messages #27
Conversation
👋 Hello tomassebestik, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
FYI @KonstantinKondrashov : That should solve your request described in internal JIRA RDT-537 |
d5a454d
to
d749ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomassebestik Thank you for the PR, the solution is ok, but how can we be sure that these fixup commits will always be squashed before the merge?
@kumekay I understand your concern, but this is probably beyond what this tool is capable of. Usually, a pre-commit linter is used along with Danger (GL or GH), and cases like unsquashed fixup commits will be caught by Danger. I don't think it would be very wise to try implement additional logic for that in the pre-commit hook for the commit linter since we probably want to keep this tool simple and straightforward. WDYT? |
This PR handles the usage of the
git commit --fixup
command.Fixup and squash messages are ignored by commit linter as they are temporary and will not remain in the git history.
Related