Bootloader compilation fails when "UART for console output" is set to "none" (GIT8266O-837)

[klew]

Environment

• Development Kit: n/a
• IDF version: 3b15c06
• Development Env: Make
• Operating System: Ubuntu
• Power Supply: n/a

Problem Description

Bootloader compilation fails when I tried to disable all console logging to UART with simple "hello_world" example.

Expected Behavior

"hello_world" should compile without any error.

Actual Behavior

Bootloader compilation fails on:

~/esp/ESP8266_RTOS_SDK/components/bootloader_support/src/bootloader_init.c:628:80: error: 'CONFIG_ESP_CONSOLE_UART_BAUDRATE' undeclared (first use in this function); did you mean 'CONFIG_ESP_CONSOLE_UART_NUM'?
     uart_div_modify(CONFIG_ESP_CONSOLE_UART_NUM, BOOTLOADER_CONSOLE_CLK_FREQ / CONFIG_ESP_CONSOLE_UART_BAUDRATE);

Steps to repropduce

1. go to hello_world example
2. run: make menuconfig and go to "Component config"->"Common ESP-related" and set "UART for console output" to "none".
3. run: make

Code to reproduce this issue

Other items if possible

This probably should be fixed in bootloader_init.c file, however below change in Kconfig solves the compilation problem, because it allows to define missing configuration define:

diff --git a/components/esp_common/Kconfig b/components/esp_common/Kconfig
index fd88fad9..f480a3de 100644
--- a/components/esp_common/Kconfig
+++ b/components/esp_common/Kconfig
@@ -86,7 +86,7 @@ menu "Common ESP-related"
 
     config ESP_CONSOLE_UART_BAUDRATE
         int "UART console baud rate"
-        depends on !ESP_CONSOLE_UART_NONE
+#        depends on !ESP_CONSOLE_UART_NONE
         default 74880
         range 1200 4000000