Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share package button #30

Open
arabello opened this issue Aug 28, 2022 · 5 comments
Open

Add share package button #30

arabello opened this issue Aug 28, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arabello
Copy link
Collaborator

arabello commented Aug 28, 2022

The hub already supports URL-based package sharing, but there is no button to easily copy the URL value. It would make sense to change the current homepage (GitHub repo) button with this functionality, while making the package title a clickable link to its homepage.

Additionally, on mobile the button could use the Web Share API.

@arabello arabello added enhancement New feature or request good first issue Good for newcomers labels Aug 28, 2022
@anmol-fzr
Copy link

Hey, @arabello I Would like to contribute to this issue.

@AucaCoyan
Copy link
Member

You can have this too. arabello is not often here, so I can cover him up. Ask me anything you need!
We are also in the espanso discord https://discord.gg/DFcCNDg7bB

@arabello
Copy link
Collaborator Author

Hi there! I'm glad you wanna contribute! feel free to ask me anything related to the codebase here or on Discord (please tag me so I can be more responsive).

Enjoy!

@anmol-fzr
Copy link

@arabello So, on what page / component are we planning to add a share button ?

@arabello
Copy link
Collaborator Author

@anmol-fzr I think the issue was already solved, but it wasn't closed. I am sorry for the misleading. It was an old self-reminder. The current package page has a share button with a pop-up menu to copy the link to the clipboard, see below for an example.

If you are still interested in making a contribution, I think we can improve the feature by removing the pop-menu and directly copy the link to the clipboard. Otherwise, it makes sense to close the issue as-it-is.

Sorry again 🙏

Screen.Recording.2024-05-20.at.21.41.37.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants