Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update templates for eslint v9 #179

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 18, 2024

  1. use flat config
  2. add .npmrc (package-lock=false), just same as eslint repo
  3. update required node.js & eslint

fixes #172

1. use flat config
2. add .npmrc (package-lock=false), just same as eslint repo
3. update required node.js & eslint
@aladdin-add
Copy link
Member Author

@mdjermanovic can you push a new release of eslint-config-eslint, to update eslint-plugin-unicorn for eslint v9 support?

.github/workflows/ci.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
@aladdin-add
Copy link
Member Author

friendly ping @mdjermanovic

@mdjermanovic
Copy link
Member

@mdjermanovic can you push a new release of eslint-config-eslint, to update eslint-plugin-unicorn for eslint v9 support?

Sorry, I missed this.

I believe eslint-config-eslint is fully ready for a new release in terms of its flat config part. But it still exports an eslintrc config, which we haven't been updating for a while and is probably out-of-sync with the flat config. Since it's a public package, my thinking was to wait for eslint/eslint#18011 (which drops the eslintrc export) before releasing new eslint-config-eslint, but I'm open to other ideas.

@aladdin-add
Copy link
Member Author

The exported eslinrc was exclusively utilized within the eslint repo. Additionally, the progress of eslint/eslint#18011 was blocked by vscode-eslint😅. I am in favor of pushing a release to unblock eslint repos upgrading to eslint v9.

@mdjermanovic
Copy link
Member

The exported eslinrc was exclusively utilized within the eslint repo

That's true for our repos, but it's still a public package used by others as well, so the expectation would be that the flat config and eslintrc exports are equivalent, which most likely isn't the case anymore. I left an idea in eslint/eslint#18011 (comment).

@aladdin-add
Copy link
Member Author

Actually eslintrc was not published to npm, so there should be no external users.

image

@mdjermanovic
Copy link
Member

Actually eslintrc was not published to npm, so there should be no external users.

Yes, but there might be when we release it. And I think it's anyway best to release eslint-config-eslint v10 without eslintrc.

@aladdin-add aladdin-add marked this pull request as ready for review April 30, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to generate eslint 9.0 plugins
3 participants