Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled release for April 19th, 2024 #18293

Closed
26 of 28 tasks
eslint-github-bot bot opened this issue Apr 8, 2024 · 7 comments
Closed
26 of 28 tasks

Scheduled release for April 19th, 2024 #18293

eslint-github-bot bot opened this issue Apr 8, 2024 · 7 comments
Assignees
Labels
release This issue contains information about a scheduled ESLint release triage:no

Comments

@eslint-github-bot
Copy link

eslint-github-bot bot commented Apr 8, 2024

The next scheduled release will occur on Friday, April 19th, 2024.

Release Day Checklist

  • Remove the 'tsc agenda' label on this issue
  • Review open pull requests and merge any that are ready
  • Verify if there are other packages (i.e., espree, eslint-scope, eslint-visitor-keys, @eslint/eslintrc) that need to be released first
  • Release @eslint/js to match the upcoming eslint version in Jenkins
  • Update package.json in the eslint repo with new versions from the preceding steps (create and merge a pull request)
  • Start the release on Jenkins
  • Update the release blog post:
    • Add a "Highlights" section for any noteworthy changes.
    • In the authors frontmatter, replace eslintbot with your GitHub username.
    • Remove the draft: true line in frontmatter.
  • Make a release announcement on Twitter
  • Make a release announcement in the Discord '#announcements' channel
  • Add a comment to this issue saying the release is out
  • Add the 'patch release pending' label to this issue

Two Days After Release Day Checklist

Typically Monday for regular releases; two days after patch releases.

  • Check the issues list for any regression issues

No Regressions Checklist

  • Remove the 'patch release pending' label from this issue
  • Close this issue

Patch Release Checklist

  • Resolve the regression by merging any necessary fixes
  • Start the release on Jenkins
  • Update the release blog post:
    • Add a "Highlights" section for any noteworthy changes.
    • In the authors frontmatter, replace eslintbot with your GitHub username.
    • Remove the draft: true line in frontmatter.
  • Make a release announcement on Twitter
  • Make a release announcement in the Discord '#announcements' channel
  • Add a comment to this issue saying the release is out
  • Wait two days and repeat the Two Days After a Release checklist
  • Close this issue

Followup

Please use this issue to document how the release went, any problems during the release, and anything the team might want to know about the release process. This issue should be closed after all patch releases have been completed (or there was no patch release needed).

Resources:

@eslint-github-bot eslint-github-bot bot added release This issue contains information about a scheduled ESLint release triage:no tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Apr 8, 2024
@fasttime fasttime self-assigned this Apr 18, 2024
@fasttime
Copy link
Member

Release plan:

  • @eslint/js v9.1.0
  • eslint v9.1.0

@fasttime fasttime removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Apr 19, 2024
@fasttime
Copy link
Member

fasttime commented Apr 19, 2024

After releasing @eslint/js v9.1.0, only while trying to upgrade the dependency in eslint's package.json, we noticed that some tests were failing, see: https://github.com/eslint/eslint/actions/runs/8759153882/job/24041878498.

To fix the build, we had to revert part of the changes of 4d11e56, (in 50d406d) and release a patch of @eslint/js v9.1.1.

@fasttime
Copy link
Member

ESLint v9.1.0 has been released:

https://eslint.org/blog/2024/04/eslint-v9.1.0-released/

Please merge semver-patch PRs only until we determine whether or not a patch release is necessary.

@fasttime fasttime added the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Apr 19, 2024
@fasttime
Copy link
Member

I'm trying to understand if #18374 is caused by a regression. According to the issue, ESLint does not stop its execution automatically, which should not happen in case of a misconfiguration.

@fasttime
Copy link
Member

ESLint v9.1.1 has been released:

https://eslint.org/blog/2024/04/eslint-v9.1.1-released/

@fasttime
Copy link
Member

The problem described in #18374 reportedly also occurs with ESLint v9.0.0 (comment), so it doesn't qualify as a regression.

@fasttime
Copy link
Member

This concludes the v9.1.0 and v9.1.1 releases. We can resume merging semver-minor changes.

@fasttime fasttime removed the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release This issue contains information about a scheduled ESLint release triage:no
Projects
None yet
Development

No branches or pull requests

1 participant