Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the sourcemap url #43

Closed
tjx666 opened this issue Mar 19, 2023 · 4 comments · Fixed by #44 · May be fixed by julitabarelkowska/eslint-utils#1
Closed

remove the sourcemap url #43

tjx666 opened this issue Mar 19, 2023 · 4 comments · Fixed by #44 · May be fixed by julitabarelkowska/eslint-utils#1
Labels
accepted bug

Comments

@tjx666
Copy link
Contributor

tjx666 commented Mar 19, 2023

image

version: [email protected]
@Rec0iL99
Copy link
Member

Hi @tjx666, thanks for the issue. The sourceMappingURL comment is autogenerated by rollup and helps navigate to the source map file and finally to the original source code during debugging. I believe this comment is generated by rollup because of sourcemap: true in rollup.config.js.

@Rec0iL99 Rec0iL99 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@tjx666
Copy link
Contributor Author

tjx666 commented Mar 19, 2023 •
edited

@Rec0iL99

You should set sourcemap: false when build for production, or it will cause debugger tools issue because you declare the sourceMappingURL but not actually exists;

image

@nzakas nzakas reopened this Mar 20, 2023
@nzakas
Copy link
Member

nzakas commented Mar 20, 2023

This is a bug. We should remove sourcemap:true in rollup.config.js.

@tjx666 do you want to submit a pull request for this?

tjx666 pushed a commit to tjx666/eslint-visitor-keys that referenced this issue Mar 22, 2023
fix: remove useless sourcemap url (eslint#43)
3125756
tjx666 pushed a commit to tjx666/eslint-visitor-keys that referenced this issue Mar 22, 2023
fix: remove useless sourcemap url (eslint#43)
90b23ec
@tjx666
Copy link
Contributor Author

tjx666 commented Mar 22, 2023

@nzakas #44

@mdjermanovic mdjermanovic linked a pull request Mar 22, 2023 that will close this issue
fix: remove useless sourcemap url (#43) #44
Merged
nzakas pushed a commit that referenced this issue Mar 23, 2023
@tjx666
fix: remove useless sourcemap url (fixes #43) (#44)
e9a070f
@data-sync-user data-sync-user mentioned this issue Oct 12, 2023
Merged
@julitabarelkowska julitabarelkowska mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug
Projects
Triage
Archived in project
Milestone
No milestone
3 participants
@nzakas @tjx666 @Rec0iL99