-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule: disallow unicode confusable identifiers #117
Comments
Related to #116 |
When you say the zero-width joiner is causing a parsing error, where do you see that? |
Oh my bad, it's because I'm using typescript-eslint, and tsc is choking on ZWJ! |
Ah okay, good to know! I was confused because the default parser was working okay. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rule details
Compute the Unicode skeleton of declared identifiers and disallow if similar to an identifier already in scope
Related CVE
CVE-2021-42694
Example code
Participation
Additional comments
The Zero-Width Joiner (
\u200d
) is a valid identifier character, even though some parsers like the ones used by typescript or Webpack fail to parse correctly.Cyrillic characters in the example code is one case of confusable unicode character with latin character, but there are a lot of other possibilities, including confusion between non-latin characters. Unicode defines an algorithm to compute the skeleton of text, which we could apply to identifiers, and base the comparison on the skeleton instead of the identifier string.
First reported in eslint/eslint#15240 (comment)
The text was updated successfully, but these errors were encountered: