Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context_id to transaction_tax & brokers_fee type journal entries #1369

Open
4 of 8 tasks
SefaOray opened this issue Nov 29, 2023 · 0 comments
Open
4 of 8 tasks

Add context_id to transaction_tax & brokers_fee type journal entries #1369

SefaOray opened this issue Nov 29, 2023 · 0 comments

Comments

@SefaOray
Copy link

Feature Request

It would be great to keep track of transaction_tax & brokers_fee per market order.

Use case

I would like to gain better insights into my production and trading transactions. Transactions tax changes based on unit price and I pay additional brokers fee when I adjust my order, which makes profit calculations very tricky.

Linking transaction_tax & brokers_fee journal entries to market orders would bring more transparency into my expenses and I can calculate more accurate expenses table for a certain trade or production project.

Authentication

Existing scope: esi-wallet.read_character_wallet.v1

Example return

Propose what an example return might look like. E.g.:

[
  {
    "amount": -3072049.27,
    "balance": 1402505658.9042,
    "date": "2023-11-29T12:15:07Z",
    "description": "Market order commission to broker authorized by: Redacted",
    "first_party_id": "CharacterId",
    "id": 9876564321,
    "reason": "",
    "ref_type": "brokers_fee",
    "second_party_id": 1000035,
    "context_id": 123456,
    "context_id_type": "market_transaction_id",
  }
]

Checklist

Check all boxes that apply to this issue:

  • Feature request description is provided
  • Use case exists
  • Feature requires a new route
  • Feature adds data to existing route
  • Feature requires new auth scope
  • Feature can reuse existing scope
  • Feature does not require auth
  • Meta feature, applies to all routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants