Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) form update #4651

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

(fix) form update #4651

wants to merge 2 commits into from

Conversation

orgilshdeee
Copy link
Contributor

@orgilshdeee orgilshdeee commented Sep 27, 2023 •
edited

[ISSUE]
#4641
#4639
#4638
#4633
#4625
#4624
#4623
#4618
#4611
#4610
#4619

Context

added validations on some fields and fixed some visual bugs on these issues

@orgilshdeee orgilshdeee self-assigned this Sep 27, 2023
This was linked to issues Sep 27, 2023
[Bug] The UI part of the "Select" field is not displayed correctly on the "Add select field" page when creating the form with the "SELECT MULTIPLE VALUE" switch on #4641
Open
[Bug] it is possible to add a checkbox without text on the "Add check field" page of the contact section when creating a new form #4639
Open
[Bug] The OPTIONS field is not a mandatory field to be filled in on the "Add checkbox field" page from the "Content" section of the form creation #4638
Open
[Bug] It is possible to create a text input field in the form without filling in the required fields #4633
Open
[Bug] It is possible to set a negative value in the "NUMBER OF PAGES" field in the "Content" section on the "Create a new form" page #4625
Open
[Bug] The value "e" is inserted into the "NUMBER OF PAGES" field in the "Content" section of the "Create a new form" page after copying and pasting the text #4624
Open
[Bug] Unable to change the NUMBER OF PAGES and save the form on the form creation page in the "Content" section after trying to save with an empty "NUMBER OF PAGES" field #4623
Open
[Bug] It is possible to create a "CallOut" form with empty fields #4618
Open
[Bug] The large margin between the text and input bar in the "CALLOUT BODY" field in the "CallOut" section of the form creation page #4611
Open
[Bug] The "forms validation failed: type: Path type is required" error message is displayed on the "Create forms" page after clicking a "Save" button #4610
Open
@orgilshdeee orgilshdeee changed the title Form update (fix) form update Sep 27, 2023
@cypress
Copy link

cypress bot commented Sep 27, 2023 •
edited

1 failed test on run #174 ↗︎

1 11 0 0 Flakiness 0

Details:

Merge 6d7fdbc into 7b89759...
Project: erxes Commit: e0be835761 ℹ️
Status: Failed Duration: 04:16 💡
Started: Sep 27, 2023 10:57 AM Ended: Sep 27, 2023 11:01 AM
Failed  cypress/tests/contacts/ui/company.cy.js • 1 failed test

View Output Video

Test Artifacts
Contacts > set tag company Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyombo-baterdene soyombo-baterdene Awaiting requested review from soyombo-baterdene

At least 1 approving review is required to merge this pull request.

Assignees

@orgilshdeee orgilshdeee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The value "e" is inserted into the "NUMBER OF PAGES" field in the "Content" section of the "Create a new form" page after copying and pasting the text [Bug] Unable to change the NUMBER OF PAGES and save the form on the form creation page in the "Content" section after trying to save with an empty "NUMBER OF PAGES" field [Bug] It is possible to create a "CallOut" form with empty fields [Bug] The large margin between the text and input bar in the "CALLOUT BODY" field in the "CallOut" section of the form creation page [Bug] The "forms validation failed: type: Path type is required" error message is displayed on the "Create forms" page after clicking a "Save" button
[Bug] It is possible to set a negative value in the "NUMBER OF PAGES" field in the "Content" section on the "Create a new form" page [Bug] It is possible to create a text input field in the form without filling in the required fields [Bug] The OPTIONS field is not a mandatory field to be filled in on the "Add checkbox field" page from the "Content" section of the form creation [Bug] it is possible to add a checkbox without text on the "Add check field" page of the contact section when creating a new form [Bug] The UI part of the "Select" field is not displayed correctly on the "Add select field" page when creating the form with the "SELECT MULTIPLE VALUE" switch on
1 participant
@orgilshdeee