-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--restrict broken in 3.0.3 #266
Comments
The only changes to the code are the CJK mentioned on the changelog and a
few comments on the code
dev/test-everything.sh (or was on src) show a even earlier that 3.0.2
"broken" commit from @maandree
I will check if i can reproduce and look if at leas i can identify the
commit or the cause
|
I can verify the following returns a rarity
but the following does not
Installed from brew, macOS Sierra 10.12.6 (16G29), fish version 2.6.0 |
I don't have time until a weekend so I will try to at least sort the possible commints so for the weekend I can check them, a list is coming
From them onward is just readme changes and addition of ponies, nothing touch the code. |
Well this look like goes beyond my initial spectatives. So the problem probably is on the installer ./setup.py on in how ponysay check the files based on what was told during instalation. |
An unmatched bracket in a pony's metadata prevented the required pickle file from being created. I made a pull request with a fix. |
Unfortunately, it doesn’t seem to solve the issue for me. I’ve cloned your repo to try it out, and ran |
@matthias4217 I believe you have to install through setup.py first, it creates the necessary file for --restrict to work. Could you try that please? |
Indeed, I’ve spoken too fast. It works fine. However it did work well even before your modifications. To sum up :
I’m not well versed in Python packaging, or Archlinux packaging, so I’m not sure why there is this difference in behaviour between package installs and manual ones. I don’t know either how things are on other Linux distributions. I might try it later on Ubuntu. Anyway, thanks a lot for the fix ! Edit : As I had already compiled the |
I've tried it again, but the current master (without my fix) really doesn't work for me. Have you uninstalled properly via setup.py before testing? Maybe the metadata file survived at Here's what I did with the master version:
|
Updating from 3.0.2_1 in brew to 3.0.3 breaks the
--restrict
option.The command
/usr/local/bin/ponysay --restrict NAME=Rarity --ponyonly
no longer shows just Rarity images but any pony.The changelog shows nothing relating to these changes.
The text was updated successfully, but these errors were encountered: