Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclosing the team identifier with double quotations #21

Open
tnake opened this issue Jan 28, 2020 · 3 comments
Open

Enclosing the team identifier with double quotations #21

tnake opened this issue Jan 28, 2020 · 3 comments

Comments

@tnake
Copy link

tnake commented Jan 28, 2020

Thank you for your work. I use this project in my product.
I encounter an issue that I can not execute my product expectedly, so that I report that issue.

I can execute my product correctly in the mode of Debug, whereas I could not execute my product which is exported from Organizer(which do Archive of product).
I've investigate Info.plist, Helper-Info.plist, and CodeSignUpdate.sh, then I've had a doubt thing that the string of 'certificate leaf[subject.OU] = MY TEAM IDENTIFIER' is not containing double quotations.
I think that above string 'MY TEAM IDENTIFIER' should be enclosing with double quotations.
So that, I propose that in line 67 of CodeSignUpdate.sh:
printf "%s" "certificate leaf[subject.OU] = ${developmentTeamIdentifier}"
replace with
printf "%s" "certificate leaf[subject.OU] = \"${developmentTeamIdentifier}\""
(i.e. ${developmentTeamIdentifier} is enclosed with double quotations).

Note that, I use Xcode 11. So, I've applied a workaround(#19).

@gregcotten
Copy link

can confirm this change is needed to build in "Release"

@tnake
Copy link
Author

tnake commented Aug 5, 2020

I've reported this issue, in doing Archive.
However, doing Archive is the use of 'Release-mode' settings. So you can see probably this issue in Release-mode build.
Does this answer your question?

@gregcotten
Copy link

I don't have a question - I am agreeing with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants