Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove log on failed lookup visible/dirty during replacement #12495

Open
awskii opened this issue Oct 25, 2024 · 1 comment
Open

remove log on failed lookup visible/dirty during replacement #12495

awskii opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
complexity:low Issue will take up to several days to fix imp1 High importance
Milestone

Comments

@awskii
Copy link
Member

awskii commented Oct 25, 2024

so required file could be just dirty, print in case file was not found at all.
Log itself is confusing user that something very bad happened but actually it's not.

WARN[10-25|16:10:37.755] [agg] lookupVisibleFileByItsRange: file not found stepFrom=92 stepTo=94 _visible=0-64;64-96; visibleFilesCount=2
WARN[10-25|16:10:37.755] visible account file of steps 92-94 not found
 
WARN[10-25|16:10:37.755] [agg] lookupVisibleFileByItsRange: file not found stepFrom=80 stepTo=88 _visible=0-64;64-96; visibleFilesCount=2
WARN[10-25|16:10:37.755] visible account file of steps 80-88 not found
 
@awskii awskii self-assigned this Oct 25, 2024
@awskii awskii added this to the 3.0.0-alpha6 milestone Oct 25, 2024
@awskii awskii added the complexity:low Issue will take up to several days to fix label Oct 25, 2024
@blxdyx
Copy link
Contributor

blxdyx commented Oct 30, 2024

So this log will not affect the file replacement?

@AskAlexSharov AskAlexSharov added the imp1 High importance label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low Issue will take up to several days to fix imp1 High importance
Projects
None yet
Development

No branches or pull requests

4 participants
@awskii @AskAlexSharov @blxdyx and others