Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on Django 1.4 support branch #30

Open
bmihelac opened this issue May 18, 2012 · 4 comments
Open

Work on Django 1.4 support branch #30

bmihelac opened this issue May 18, 2012 · 4 comments

Comments

@bmihelac
Copy link

Hi all,

I am trying to make django-test-utils works nicely with django 1.4. My work is available here:

https://github.com/bmihelac/django-test-utils/tree/django-1.4

Currently there is one test failing. I cannot find and now I am out of ideas, why context is not assigned to response in TestMakerMiddleware (https://github.com/bmihelac/django-test-utils/blob/django-1.4/test_utils/testmaker/middleware/testmaker.py#L68).

If I duplicate same line:

response = c.get(request.path, getdict)

second response will have contextassigned.

Any help will be appreciated.

@bmihelac
Copy link
Author

I found that this is related to django test client behavior. I filled a ticket on django issue tracker.

@ericholscher
Copy link
Owner

Awesome work. Feel free to send a pull request to this repo and I'll gladly merge it in.

Cheers,
Eric

@bmihelac
Copy link
Author

Great news - I would wait a little more time with pull request, to see if related django issue and patch get accepted. When that happen, I plan to just skip failing test for django version smaller then django 1.5 or 1.4.1.

Then I'll make pull request.

cheers,
Bojan

@bmihelac
Copy link
Author

Little update on this - Django issue that prevented all tests to pass has been finally fixed in this commit:

django/django@0cac4fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants