Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with --experimental_cc_implementation_deps #30

Open
HappyCerberus opened this issue Nov 4, 2022 · 2 comments
Open

Doesn't work with --experimental_cc_implementation_deps #30

HappyCerberus opened this issue Nov 4, 2022 · 2 comments

Comments

@HappyCerberus
Copy link

It seems that the implementation dependencies are not included in the compilation context, so clang-tidy doesn't see the headers.

I tried to debug this problem, but I actually have no idea where bazel puts the implementation dependencies since they are not in the sandbox directory.

@jelle282
Copy link

FYI ran into the same issue, one suggestion I got to my question on the bazel slack channel was to walk the implementation_deps manually, which seems to work. It was by design that the compilation context only returns public properties.

Unsure whether manually combining all the depset propererties of the target's compilation context, as well as the implementation_dep's compilation contexts, is a general solution, but it seems to work in our case.

@zpzjzj
Copy link

zpzjzj commented Mar 14, 2023

  1. I overcome this by adding implementation compilation_contexts zpzjzj@867182a
  2. Bazel 6.0.0 may fix this, I did not tested yet : implementation_deps are not linked by cc_shared_library or cc_binary with dynamic_deps bazelbuild/bazel#14731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants