Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret fields should be identified as such #7

Open
displague opened this issue Jun 23, 2023 · 1 comment
Open

Secret fields should be identified as such #7

displague opened this issue Jun 23, 2023 · 1 comment

Comments

@displague
Copy link
Member

Secret fields should be identified as such.

code.setSecret('...') should be applied on metal_auth_token and perhaps user_data to prevent leaking secrets in GH Action job logs.

https://github.com/actions/toolkit/blob/main/packages/core/README.md#setting-a-secret

@cprivitere
Copy link
Member

Should also add the registration token to that. In the current testing I'm doing, those are stored as secrets so they're getting masked already. I should try inputting them differently for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants