You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default of the prop color of the Popover component is currently "#1b1a1f" as stated here.
As you can see in the screenshot, the background-color: var(--va-popover-content-background-color) of .va-popover__content is overwritten by the inline style background-color: #1b1a1. The CSS variable --va-popover-content-background-color is defined as --va-background-primary as you can see here.
Optimally the default of the prop color should not overwrite this css rule of .va-popover__content.
One possible solution would be to set the default of the prop color to backgroundPrimary.
But maybe it would make more sense to not have a default at all and just get the background-color from the CSS rule of .va-popover__content, and only overwrite it with an inline style, if the color prop is set.
Color props have higher priority over CSS variables right now. We're working on an intuitive instrument for CSS variables which is going to resolve this issue. Basically, color prop should become CSS variable.
Vuestic-ui version: 1.9.11
Description
The default of the prop
color
of the Popover component is currently"#1b1a1f"
as stated here.As you can see in the screenshot, the
background-color: var(--va-popover-content-background-color)
of.va-popover__content
is overwritten by the inline stylebackground-color: #1b1a1
. The CSS variable--va-popover-content-background-color
is defined as--va-background-primary
as you can see here.Optimally the default of the prop
color
should not overwrite this css rule of.va-popover__content
.One possible solution would be to set the default of the prop
color
tobackgroundPrimary
.But maybe it would make more sense to not have a default at all and just get the
background-color
from the CSS rule of.va-popover__content
, and only overwrite it with an inline style, if thecolor
prop is set.Reproduction
Playground Link
The text was updated successfully, but these errors were encountered: