Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS variable changing #981

Open
m0ksem opened this issue Jul 29, 2021 · 3 comments · May be fixed by #4261
Open

CSS variable changing #981

m0ksem opened this issue Jul 29, 2021 · 3 comments · May be fixed by #4261
Labels
external Reported by external contributor and handled with priority feature Something useful to end user good first issue Right issue if you're new to vuestic research Requires research v2: nice to have This will make Vuestic feel better

Comments

@m0ksem
Copy link
Collaborator

m0ksem commented Jul 29, 2021 •
edited
Loading

image

Would be nice to have this:

<va-select css-variables="{ '--va-select-background-color': '#ff0ff0' }" />
//or
<va-select css-variables="{ 'select-background-color': '#ff0ff0' }" />

To make it possible we need to move CSS variables from :root to .va-component-root-class.

This can be turn to some component style service.
@m0ksem m0ksem added external Reported by external contributor and handled with priority feature request labels Jul 29, 2021
@Derranion Derranion self-assigned this Jul 29, 2021
@asvae
Copy link
Member

asvae commented Sep 16, 2021

@m0ksem can you provide some details? I'm not entirely following.

@m0ksem
Copy link
Collaborator Author

m0ksem commented Sep 16, 2021

For now, we can change globally SCSS variables. But we can change them directly on DOM element. There will be some updates in vue3 that allow us to change CSS variables as reactive data.

I wanted to have something like this before https://codepen.io/richardtallent/pen/yvpERW/. But there is a better way to use this new feature https://v3.vuejs.org/api/sfc-style.html#state-driven-dynamic-css.

So I think this issue is not relevant anymore, except fixing VaSelect CSS variables style. They should work the same way as in VaDatePicker component.

@Derranion Derranion removed their assignment Sep 28, 2021
@asvae asvae added feature Something useful to end user and removed feature request labels Nov 25, 2021
@asvae asvae added the research Requires research label Dec 2, 2021
@m0ksem m0ksem self-assigned this Apr 7, 2022
@m0ksem m0ksem added the good first issue Right issue if you're new to vuestic label May 5, 2022
@m0ksem
Copy link
Collaborator Author

m0ksem commented May 5, 2022

Can be made the same way as withTransportConfig.

@m0ksem m0ksem removed their assignment May 19, 2022
@asvae asvae added v2: nice to have This will make Vuestic feel better and removed LOW PRIORITY labels Feb 24, 2023
@m0ksem m0ksem linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Reported by external contributor and handled with priority feature Something useful to end user good first issue Right issue if you're new to vuestic research Requires research v2: nice to have This will make Vuestic feel better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: style attribute m0ksem/vuestic-ui
3 participants
@asvae @Derranion @m0ksem