-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading a story state doesn't rollback the error stack #29
Comments
That's a very good catch, thanks for raising it! I've made error reporting more explicit in the latest version. Now, in debug, the execution is interrupted immediately when the runtime encounters an error.
Good idea, setting the state should clear everything and restore the story. I'll make it happen! I originally didn't want to allow the story to continue because of the lack of exceptions in GDScript. I'm not certain that my home-cooked logic based on
I think it would be nearly impossible to do properly in inkgd. Resetting |
Yes, imho the only right way would be to embed that information into the state itself and use it during restoration. |
Hey 馃槃
Let's consider the following code.
The expected behavior would be for everything after the new state is loaded to go on smoothly. But at the moment, story execution will stop when
continue()
is called and the stacked error will be displayed. The error stack needs to be cleared out andInkRuntime.should_interrupt
should be reset.The tricky part would be to determine if some errors are from before the state was saved or not.
E.g.
Depending on which state (
state1
orstate2
) is loaded on the last line, the rollback should probably not be the same.Environment:
The text was updated successfully, but these errors were encountered: