#1074: Add imports of previous root package in new subpackages to avoid dependency upgrade issues. #1075
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency upgrade issues. Those changes are based on https://go.dev/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository Fixes #1074 Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
force-pushed
the
vr/import-deps-fix
branch
from
4e25fcd to
496e667
Compare
mmorel-35
previously approved these changes
Dec 24, 2024
valerian-roche
force-pushed
the
vr/import-deps-fix
branch
from
fad47d7 to
56f953f
Compare
|
Also added a fix to |
…ure envoy API sync does not purge files it should not Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
force-pushed
the
vr/import-deps-fix
branch
from
56f953f to
2d17ab9
Compare
codyoss
reviewed
Dec 24, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/envoyproxy/go-control-plane/contrib | |||
|
|
|||
| go 1.21 | |||
| go 1.22.8 | |||
There was a problem hiding this comment.
nit: it would be great if the go.mod version can remain the same for this fix.
There was a problem hiding this comment.
This version is automatically updated due to the added dependency on the root-level go.mod which has been using 1.22.8 for some time.
If a blocker I can see to rollback this change but it is not, per se, part of the module split, as the new version of the main module would have also changed this
Arkelenia
reviewed
Dec 26, 2024
| go 1.22.8 | ||
|
|
||
| // Used to resolve import issues related to go-control-plane package split (https://github.com/envoyproxy/go-control-plane/issues/1074) | ||
| replace github.com/envoyproxy/[email protected] => ../ |
There was a problem hiding this comment.
Is there a reason for pinning the version here but not in the go.mod files for examples/dyplomat and ratelimit packages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module split seems to be breaking when the
get -ucommand is used.Using the link referred in this post, this change attempts to address the issue.
While I was able to test this change within one of our repository depending on this repository (for go-control-plane and envoy API), I do not know of a way to guarantee that this will resolve all cases.
Fixes #1074