-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: adds hits_addend specifier to RateLimitRule #4957
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4957 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 209 209
Lines 32052 32052
=======================================
Hits 21384 21384
- Misses 9388 9390 +2
+ Partials 1280 1278 -2 ☔ View full report in Codecov by Sentry. |
feel like maybe calling it "weight" instead of usage maybe be better? idk |
// Number specifies the fixed usage number to reduce the rate limit counters. | ||
// | ||
// +optional | ||
// +notImplementedHide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden until envoyproxy/ratelimit#802
// https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto.html#config-route-v3-ratelimit-hitsaddend | ||
// | ||
// +optional | ||
// +notImplementedHide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden until envoyproxy/ratelimit#802
will add the cel validation this afternoon (in japan) |
maybe simply Usage->HitAddends would be consistent |
@zirain @zhaohuabing ptal - I removed the implementation-hide as envoyproxy/ratelimit#802 got merged |
i will do the implementation in a subsequent PR |
@mathetake the implementation comment is used to hide the unimplemented EG API in the EG docs, we normally hide the API at the API PR and unhide it at the implementation PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Prefer to hide the API in the docs as it's not implemented yet.
ah ok - will do |
@zhaohuabing hid the APIs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hold for a while as @arkodg may want to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM defer to @arkodg
👍 |
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
c125ff2
to
d1b3de3
Compare
What type of PR is this?
This adds a new API into rate limit API.
What this PR does / why we need it:
This is for #4756. Basically, this adds the API to specify the hits_addend for the rate limit rule.
Especially, configuring the hits_addend in the response_path allows us to "reduce" the counter
based on the response content that affects the subsequent requests. This will enable the "token"
based request limits that are required fro AI gateway.
This is based on the Envoy's brand new features called apply_on_stream_done
and per-descriptor level hits_addend configuration introduced in
Which issue(s) this PR fixes:
#4756
Release Notes: No (until the implementation is done)