Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local ratelimit: support apply_on_stream_done for local rate limit #37790

Open
wbpcode opened this issue Dec 23, 2024 · 0 comments
Open

local ratelimit: support apply_on_stream_done for local rate limit #37790

wbpcode opened this issue Dec 23, 2024 · 0 comments
Assignees
@wbpcode
Labels
area/ratelimit enhancement Feature requests. Not bugs or questions.

Comments

@wbpcode
Copy link
Member

wbpcode commented Dec 23, 2024

Title: local ratelimit: support apply_on_stream_done for local rate limit

Description:

apply_on_stream_done was introduced to support post-commit of usage. It make sense to limit the resource usage that could only get from the response.

But it's not supported now for local rate limit.

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@wbpcode wbpcode added enhancement Feature requests. Not bugs or questions. triage Issue requires triage area/ratelimit and removed triage Issue requires triage labels Dec 23, 2024
@wbpcode wbpcode self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbpcode wbpcode

Labels
area/ratelimit enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbpcode