-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to see Trace Id in Access Logs when request is rate limited (429) #34102
Labels
area/access_log
area/tracing
enhancement
Feature requests. Not bugs or questions.
help wanted
Needs help!
Comments
ravenblackx
added
area/tracing
area/ratelimit
area/access_log
and removed
triage
Issue requires triage
labels
May 13, 2024
Yeah. We can extend the substitution formatter to output the trace id and span id (downstream request span id) from the active span directly. As far as I know, the active span is part of the |
wbpcode
added
enhancement
Feature requests. Not bugs or questions.
help wanted
Needs help!
and removed
bug
area/ratelimit
labels
May 16, 2024
ok, will add a new formatter |
cancecen
pushed a commit
to cancecen/envoy
that referenced
this issue
May 23, 2024
Risk Level: low Testing: unit test Docs Changes: formatter documented Release Notes: add Fixes envoyproxy#34102 Signed-off-by: zirain <[email protected]> Signed-off-by: Can Cecen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/access_log
area/tracing
enhancement
Feature requests. Not bugs or questions.
help wanted
Needs help!
%REQ(traceparent)%
is not working when request is rate limitedcc @wbpcode
The text was updated successfully, but these errors were encountered: