Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement piggy-backing of echo messages #8

Open
fjarri opened this issue Oct 12, 2024 · 0 comments
Open

Implement piggy-backing of echo messages #8

fjarri opened this issue Oct 12, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 12, 2024

Currently when a round needs an echo-broadcast, we run it as a separate round. Theoretically, we could send those messages alongside the messages from the next round. But there are multiple possibilities that will complicate the execution logic:

  • There may be no next round at all, so we need to run another round anyway just for the echo;
  • If there's a failure in the next round, the evidence may require the echoed messages. So we need to make sure that we finish the echo round and collect those messages before constructing an evidence;
  • The list of destinations for the previous and the next round may be different, so some nodes will only get the echo round messages, some will get the new round messages, and some will get both.

Maybe there's something else I haven't thought of. This will make the logic much more complicated for, honestly, a rather modes benefit. Or at least that's how it seems to me now. I'll leave this open for a while in case someone comes up with a way to implement it without a combinatorial explosion.

@fjarri fjarri added the enhancement New feature or request label Oct 12, 2024
@fjarri fjarri added this to the v1.0.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant