Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge some of the Round methods #69

Open
fjarri opened this issue Nov 14, 2024 · 0 comments
Open

Merge some of the Round methods #69

fjarri opened this issue Nov 14, 2024 · 0 comments
Labels
API Involves backwards-incompatible changes of the public API
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 14, 2024

Round has several methods that deal with the round's position in the state transition graph:

Similarly, there are three methods dealing with how the node interacts with other nodes during the round (intersects with #4):

  • fn message_destinations(&self) -> &BTreeSet<Id>,
  • fn expecting_messages_from(&self) -> &BTreeSet<Id>,
  • to be added in Logic fixes for rounds with partial echo #67, fn echo_round_participation(&self) -> EchoRoundParticipation<Id>.

Does it make sense to merge either of the group into one method returning an enum? Which possibilities do we need to cover?

@fjarri fjarri added the API Involves backwards-incompatible changes of the public API label Nov 14, 2024
@fjarri fjarri added this to the v0.2.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API
Projects
None yet
Development

No branches or pull requests

1 participant