Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend example/tests/async.rs to offload message creation/processing to separate tasks #22

Open
fjarri opened this issue Oct 12, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation tests Testing things
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 12, 2024

This will demonstrate the target usage pattern for a heavy protocol.

Also I have a suspicion that we won't actually be able to finalize() because it consumes the Session object, and references to it are being sent to tasks, so we will have to wait for all of them to finish, which we won't want to do if there's a threshold needed to finalize (see also #11). So we will need to think of some different API to support this case.

@fjarri fjarri added the tests Testing things label Oct 12, 2024
@fjarri
Copy link
Member Author

fjarri commented Oct 30, 2024

As evidenced by entropyxyz/entropy-core#1136, there don't seem to be any problems with parallel processing. But it raises another question: how do we test the performance gain from it in a real protocol? Should run_sync() optionally offload message processing to threads?

@fjarri fjarri added the documentation Improvements or additions to documentation label Nov 4, 2024
@fjarri fjarri added this to the v0.2.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Testing things
Projects
None yet
Development

No branches or pull requests

1 participant