-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming: ViewWithoutOverflow #24
Comments
there are some images and explanations here https://medium.com/entria/solving-view-overflow-in-android-reactnative-f961752a75cd maybe we can add those to readme.md |
I understand what this module does, but the naming is confusing. What are you trying to convey with the name |
naming things is a hard problem what would be a good name? |
In my code base, I name it like this;
This doesn’t change how it appears when inspecting of course, but it makes a lot more sense to me anyway. For iOS, you could simply exit early and return |
|
Seeing this when inspecting the view hierarchy is just really confusing, be it if you’re on iOS or Android. Why was it named this way, when the whole point of this module is to enable overflow?
The text was updated successfully, but these errors were encountered: