Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming: ViewWithoutOverflow #24

Open
Haraldson opened this issue May 24, 2018 · 5 comments
Open

Naming: ViewWithoutOverflow #24

Haraldson opened this issue May 24, 2018 · 5 comments
Labels
question Further information is requested

Comments

@Haraldson
Copy link

Haraldson commented May 24, 2018

Seeing this when inspecting the view hierarchy is just really confusing, be it if you’re on iOS or Android. Why was it named this way, when the whole point of this module is to enable overflow?

@sibelius
Copy link
Member

there are some images and explanations here https://medium.com/entria/solving-view-overflow-in-android-reactnative-f961752a75cd

maybe we can add those to readme.md

@Haraldson
Copy link
Author

I understand what this module does, but the naming is confusing. What are you trying to convey with the name ViewWithoutOverflow? What does it mean that it is without overflow?

@sibelius
Copy link
Member

naming things is a hard problem

what would be a good name?

@Haraldson
Copy link
Author

In my code base, I name it like this;

import OverflowableView from 'react-native-view-overflow'

This doesn’t change how it appears when inspecting of course, but it makes a lot more sense to me anyway. For iOS, you could simply exit early and return View as-is, perhaps?

@sibelius sibelius added the question Further information is requested label May 25, 2018
@sibelius
Copy link
Member

Overflowable looks good, we gonna think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants