Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Family Issue #65

Open
manishbisht opened this issue Aug 7, 2019 · 7 comments
Open

Font Family Issue #65

manishbisht opened this issue Aug 7, 2019 · 7 comments

Comments

@manishbisht
Copy link

iOS uses the PostScript name of the font. The Postscript name is changed in the Font Awesome 5.9 and the PostScript name is now FontAwesome5Free-Solid

Screen Shot 2019-08-07 at 11 16 16 AM

Screen Shot 2019-08-07 at 11 16 44 AM

Screen Shot 2019-08-07 at 11 18 46 AM

@manishbisht
Copy link
Author

If this issue gets confirmed. I can submit the fix and send the PR.

@leandrosimoes
Copy link
Collaborator

leandrosimoes commented Aug 7, 2019

If this issue gets confirmed. I can submit the fix and send the PR.

Hi @manishbisht ! Try to use this font files there is in the new sample/ project that I made. This files match the font family names. I changed the downlod url in the documentation, but this was not merged yet as you can see at this PR: #64

So, would be nice if you open a new PR to change the font families, update this font files too in the sample/ project and make sure that everything is working with the new font families and files.

UPDATE: Fix font files url

@sspiff
Copy link

sspiff commented Aug 15, 2019

Changing the fontFamily like so is an easy workaround:

import FontAwesome, { SolidIcons } from 'react-native-fontawesome'
SolidIcons._fontFamily = 'FontAwesome5Free-Solid'

@leandrosimoes
Copy link
Collaborator

leandrosimoes commented Aug 16, 2019

Changing the fontFamily like so is an easy workaround:

import FontAwesome, { SolidIcons } from 'react-native-fontawesome'
SolidIcons._fontFamily = 'FontAwesome5Free-Solid'

Did you try to use this font file? The files are from the sample project and the sample project was tested in both, android and ios, and it is all working.

@sspiff
Copy link

sspiff commented Aug 16, 2019

Changing the fontFamily like so is an easy workaround:

import FontAwesome, { SolidIcons } from 'react-native-fontawesome'
SolidIcons._fontFamily = 'FontAwesome5Free-Solid'

Did you try to use this font file? The files are from the sample project and the sample project was tested in both, android and ios, and it is all working.

No, I had followed the link to the font files in the (outdated?) README on npmjs.com (which point to fontawesome.com).

@leandrosimoes
Copy link
Collaborator

Changing the fontFamily like so is an easy workaround:

import FontAwesome, { SolidIcons } from 'react-native-fontawesome'
SolidIcons._fontFamily = 'FontAwesome5Free-Solid'

Did you try to use this font file? The files are from the sample project and the sample project was tested in both, android and ios, and it is all working.

No, I had followed the link to the font files in the (outdated?) README on npmjs.com (which point to fontawesome.com).

Yeah, the npm README is outdated, unfortunately. I'll open an Issue to update that asap. Try to use the font files from the link that I told you, I think that it will work.

@vini-btc
Copy link

The suggested fix will only work for the free version of the font, though. If using Pro - like I was trying to -, one will likely have to come up with a different workaround. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants