Stream decrypted buffer on the fly #963
esrk
started this conversation in
Feature requests
Replies: 3 comments
-
Hey @esrk, this is a great suggestion. Thanks for creating the issue. From what I recall, the current video player does not accept a buffer/stream. So we might have to modify the underlying player to make this happen. I'll keep this issue open since this is something we intend to ship. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Please implement the streaming option for videos, that would be awesome! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Related to this suggestion.
Currently download, decrypt and file view are sequential operations, i.e each operation runs for the full file before the next can begin. While this is relatively fine for images, viewing videos is currently not optimal, especially for large files.
An alternative would be to stream buffers in all the 3 operations in parallel threads. Ente encrypts in blocks of size 4MB, so each operation can chain the response in blocks of
decryptionChunkSize
bytes to the next one without waiting for the complete file.Implementing cache could be relatively trickier, especially with remote seek being possible now. Maybe this could be shipped as a beta feature which disables video controls until cache is implemented for buffers. IMO even without cache, progressive video playing is a huge win.
Note: The same buffer loading could be reused for images too.
Beta Was this translation helpful? Give feedback.
All reactions