Ente Auth sends HTML-only emails for login verification

[SiteRelEnby]

Description

Massive pain if there is only a terminal-based or similar email client. Email should have both plain text and HTML parts.

Happy to fix myself if pointed in the right direction.

Version

No response

What product are you using?

Ente Auth

What platform are you using?

Mobile - Android, Desktop - Linux, Desktop - Windows

Not a good UX for the login workflow.

[vishnukvmd]

Hey, thanks for offering to help!

I'm not familiar with the protocol for appending a plain-text version via SMTP, but here's the code path for sending mails:

ente/server/pkg/utils/email/email.go

Lines 32 to 93 in e7ca750

	func sendViaSMTP(toEmails []string, fromName string, fromEmail string, subject string, htmlBody string, inlineImages []map[string]interface{}) error {
	if len(toEmails) == 0 {
	return ente.ErrBadRequest
	}
	smtpServer := viper.GetString("smtp.host")
	smtpPort := viper.GetString("smtp.port")
	smtpUsername := viper.GetString("smtp.username")
	smtpPassword := viper.GetString("smtp.password")
	var emailMessage string
	// Construct 'emailAddresses' with comma-separated email addresses
	var emailAddresses string
	for i, email := range toEmails {
	if i != 0 {
	emailAddresses += ","
	}
	emailAddresses += email
	}
	header := "From: " + fromName + " <" + fromEmail + ">\n" +
	"To: " + emailAddresses + "\n" +
	"Subject: " + subject + "\n" +
	"MIME-Version: 1.0\n" +
	"Content-Type: multipart/related; boundary=boundary\n\n" +
	"--boundary\n"
	htmlContent := "Content-Type: text/html; charset=us-ascii\n\n" + htmlBody + "\n"
	emailMessage = header + htmlContent
	if inlineImages == nil {
	emailMessage += "--boundary--"
	} else {
	for _, inlineImage := range inlineImages {
	emailMessage += "--boundary\n"
	var mimeType = inlineImage["mime_type"].(string)
	var contentID = inlineImage["cid"].(string)
	var imgBase64Str = inlineImage["content"].(string)
	var image = "Content-Type: " + mimeType + "\n" +
	"Content-Transfer-Encoding: base64\n" +
	"Content-ID: <" + contentID + ">\n" +
	"Content-Disposition: inline\n\n" + imgBase64Str + "\n"
	emailMessage += image
	}
	emailMessage += "--boundary--"
	}
	// Send the email to each recipient
	for _, toEmail := range toEmails {
	auth := smtp.PlainAuth("", smtpUsername, smtpPassword, smtpServer)
	err := smtp.SendMail(smtpServer+":"+smtpPort, auth, fromEmail, []string{toEmail}, []byte(emailMessage))
	if err != nil {
	return stacktrace.Propagate(err, "")
	}
	}
	return nil
	}

This function could optionally accept a plainTextBody.