Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View.js entity helper doesnt check for undefined position, scale, and/or rotation #440

Open
beewyka819 opened this issue Feb 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@beewyka819
Copy link
Contributor

beewyka819 commented Feb 11, 2021

The helper() function in View.js currently doesn't check for position, scale, and/or rotation being defined before trying to access their values. This results in MYR crashing if one or more of these fields are undefined.

Suggest adding code that catches this and defaults to 1 instead of hard crashing. Possibly log a warning to the console as well.

@beewyka819 beewyka819 added the bug Something isn't working label Feb 11, 2021
@beewyka819 beewyka819 self-assigned this Feb 11, 2021
@beewyka819 beewyka819 removed their assignment Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant