Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend theme will make radix colors unavailable when matching Uno preset is equivalent. #21

Open
sannajammeh opened this issue Dec 7, 2023 · 1 comment

Comments

@sannajammeh
Copy link

Right now we only have 2 options, either extend or remove all defaults. The issue is this line:

       ...(extend ? theme.colors : []),

It's applied after adding the radix colors, meaning for colors like mauve, Uno will prefer the default theme colors. I suggest a way to add this at the start, or similarly a way to not only prefix css variables but also prefix the generated color matchers so I can write bg-radix-<color> and keep the default uno colors for themselves.

@endigma
Copy link
Owner

endigma commented Dec 8, 2023

I'd accept a PR for this, but unfortunately I don't have a lot of time to work on this library at the moment. It's used internally at my company and iterating on it isn't a priority. If you can wait I'll probably get to it soon, but I'd accept a PR that adds a global prefix or somehow fixes the load order.

This solution could also try and resolve #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants