Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable branch = true for coverage.run #2452

Open
Kludex opened this issue Jan 31, 2024 · 7 comments
Open

Enable branch = true for coverage.run #2452

Kludex opened this issue Jan 31, 2024 · 7 comments
Labels
good first issue Good for beginners

Comments

@Kludex
Copy link
Member

Kludex commented Jan 31, 2024

The goal here is to enable branch = true on tool.coverage.run. We want to be able to cover all logic paths.

@Kludex Kludex added the good first issue Good for beginners label Jan 31, 2024
ShreySinha02 added a commit to ShreySinha02/starlette that referenced this issue Feb 15, 2024
@ShreySinha02
Copy link

ShreySinha02 commented Feb 15, 2024

opened #2513

@ShreySinha02
Copy link

can not pass on --fail-under=100 but on 99 it can pass the the coverage

@Kludex
Copy link
Member Author

Kludex commented Feb 15, 2024

Well, the goal is exactly to add tests...

@TechNiick
Copy link
Contributor

There was already a PR open for this issue here.
I have started to work on test coverage. The first PR was opened here.
After merging this first one I will continue with the rest of them.

@hoenie-ams
Copy link

Fund with Polar

FYI @Kludex : The link doesn't work (404)

@Kludex
Copy link
Member Author

Kludex commented Dec 4, 2024

Fund with Polar

FYI @Kludex : The link doesn't work (404)

We are not using polar. They don't remove the links after you remove the integration.

@lealre
Copy link
Contributor

lealre commented Dec 12, 2024

Putting the table to make it easier to identify:

Name Branch BrPart Cover Missing
starlette/_utils.py 14 1 98% 78->82
starlette/endpoints.py 20 1 99% 77->72 (#2804)
starlette/middleware/gzip.py 22 2 98% 16->22, 91->exit
starlette/middleware/wsgi.py 28 1 99% 124->exit (#2804)
starlette/requests.py 96 3 99% 114->116, 233->225, 253->278
starlette/responses.py 118 1 99% 117->124 (#2804)
starlette/routing.py 164 3 99% 199->202, 401->430, 484->496
starlette/staticfiles.py 44 1 99% 207->212 (#2804)
starlette/templating.py 22 1 99% 46->56 (#2804)
TOTAL 2016 14 99%

Let me know if there is any inconsistency in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners
Projects
None yet
Development

No branches or pull requests

5 participants