Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentification docs reference non-existing class #3203

Open
alexprengere opened this issue May 17, 2024 · 2 comments
Open

Authentification docs reference non-existing class #3203

alexprengere opened this issue May 17, 2024 · 2 comments

Comments

@alexprengere
Copy link
Contributor

The auth docs reference httpx.BasicAuthentication() 3 times, but this class does not exist, it should be replaced with httpx.BasicAuth().
@tomchristie
Copy link
Member

Oh thanks for noticing. Would you like to submit a PR resolving this?

@alexprengere
Copy link
Contributor Author

alexprengere commented Jun 6, 2024 •
edited

It looks like such a PR was already merged: https://github.com/encode/httpx/pull/3112/files
There is also a discussion about this: #3137
So most likely the docs are just not up-to-date with the repository, as perhaps this depends on a new release being done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchristie @alexprengere