Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated images documentation #123

Open
MichalBryxi opened this issue May 23, 2021 · 2 comments
Open

Outdated images documentation #123

MichalBryxi opened this issue May 23, 2021 · 2 comments

Comments

@MichalBryxi
Copy link

I think following sentence from the documentation is not correct anymore? Empress is not using ember-responsive-image, which should solved this automagically?

Important Note: empress-blog does not currently have automatic image resizing, so it's always a good idea to make sure your images aren't gigantic files before adding them to your project.

@elwayman02
Copy link
Contributor

empress-blog itself doesn't have automatic image sizing, but the Casper template provides it I believe? However, since the Casper template isn't part of this project directly, the documentation for empress-blog itself should reflect that it isn't included. That said, it would be a nice improvement to point out in the docs that the default template has this capability.

@MichalBryxi
Copy link
Author

Agree. The reality of things is that most people will opt for default template. So even having a note in empress-blog README that "solution for this common thing can be found here" will be highly useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants